Adds a RFC overview #23
Conversation
✅ Deploy Preview for ember-rfcs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
May need to add library to the prerender URLs |
| const result = []; | ||
|
|
||
| for (let fileContents of data) { | ||
| result.push({number: fileContents.number, link: fileContents.rfcFile, title: fileContents.title,stage: fileContents.currentStage}); |
There was a problem hiding this comment.
since we're showing proposed things we won't always have a link to the rfcFile 🤔 should we also be exposing github links? what is the UX around this?
There was a problem hiding this comment.
Good question, I think we might want to add the GitHub links as a seperate thing (with the open external link icon) so that it's clearer what a link means.
There was a problem hiding this comment.
yea I agree, but I think it's probably fine to default to linking to the actual RFC when it's available 👍
|
For documentation purposes: My use case is to quickly find the canonical URL for an RFC at release time so that it can be referenced in CHANGELOGs and blog posts. |
With the new design we broke @kategengler's workflow of searching for an RFC in the side menu, so we now have the library page, showing the number, title and the stage. The only thing we need to figure out is the linking thing when RFCs are closed/merged or still in proposed stage. We can merge this now, and fix that later, or maybe I can fix it tomorrow.
